Skip to content

x/website: add log/slog handler guide (https://golang.org/s/slog-handler-guide) #61239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbkane opened this issue Jul 9, 2023 · 4 comments
Closed
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bbkane
Copy link

bbkane commented Jul 9, 2023

What is the URL of the page with the issue?

https://pkg.go.dev/log/slog#hdr-Writing_a_handler

Linking to https://golang.org/s/slog-handler-guide (broken link)

What is your user agent?

Mozilla/5.0 (Android 13; Mobile; rv:109.0) Gecko/115.0 Firefox/115.0

Screenshot

n/a

What did you do?

Head to https://pkg.go.dev/log/slog#hdr-Writing_a_handler

Click on the https://golang.org/s/slog-handler-guide link

What did you expect to see?

A guide about slog handlers

What did you see instead?

"not found"

@bbkane bbkane added the pkgsite label Jul 9, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 9, 2023
@bbkane bbkane changed the title x/pkgsite: broken slog handler link x/pkgsite: broken slog handler gude link Jul 9, 2023
@bbkane bbkane changed the title x/pkgsite: broken slog handler gude link x/pkgsite: broken slog handler guide link Jul 9, 2023
@seankhliao seankhliao changed the title x/pkgsite: broken slog handler guide link log/slog: broken slog handler guide link Jul 9, 2023
@seankhliao seankhliao added Documentation Issues describing a change to documentation. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed pkgsite labels Jul 9, 2023
@ianlancetaylor
Copy link
Contributor

CC @jba

There is indeed no such short link, and I'm not sure what it should link to.

@jba
Copy link
Contributor

jba commented Jul 11, 2023

This is https://go.dev/cl/494576, which is in progress.
I would rather roll forward by finishing that doc.
I will aim to do so by early next week.

@jba jba added release-blocker and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 11, 2023
@cherrymui cherrymui modified the milestones: Unreleased, Go1.21 Jul 11, 2023
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 11, 2023
@cherrymui
Copy link
Member

As this is not in the main repo we will remove the release blocker label. @jba already has a CL out and hopefully we can get it in soon. Thanks.

@cherrymui cherrymui modified the milestones: Go1.21, Unreleased Jul 12, 2023
@cherrymui cherrymui changed the title log/slog: broken slog handler guide link x/website: add log/slog handler guide https://golang.org/s/slog-handler-guide Jul 12, 2023
@cherrymui cherrymui changed the title x/website: add log/slog handler guide https://golang.org/s/slog-handler-guide x/website: add log/slog handler guide (https://golang.org/s/slog-handler-guide) Jul 12, 2023
@jba
Copy link
Contributor

jba commented Jul 14, 2023

The link now points to a valid page.

The actual document is just a stub at the moment, but we won't track its progress here.

@jba jba closed this as completed Jul 14, 2023
@golang golang locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

6 participants