Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/xml: undocumented Reset method #6125

Closed
robpike opened this Issue Aug 13, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@robpike
Copy link
Contributor

robpike commented Aug 13, 2013

As reported by cmd/api (yay bradfitz) xml.Encoder now has an undocumented Reset method.
This arose when the same method arrived for bufio.Writer. It's not the only secret
method.  http://play.golang.org/p/PDNKC2oMsN


Let's tidy this up.
@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Aug 13, 2013

Comment 1:

Please, no one start working on this. I have many pending changes to the xml package and
will do this once they are in.

Owner changed to @rsc.

Status changed to Started.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Aug 13, 2013

Comment 2:

There are two bugs here.
One is fixing godoc to reflect reality, using go/types.  I filed issue #6127 for that.
This bug is about hiding the embedded methods from the xml package.
This commit shows the always-there-but-never-promised methods that we now know about:
https://code.google.com/p/go/source/detail?r=f5b37c93e4c5bb2962c
pkg encoding/xml, method (Encoder) Available() int
pkg encoding/xml, method (Encoder) Buffered() int
pkg encoding/xml, method (Encoder) Flush() error
pkg encoding/xml, method (Encoder) Write([]uint8) (int, error)
pkg encoding/xml, method (Encoder) WriteByte(uint8) error
pkg encoding/xml, method (Encoder) WriteRune(int32) (int, error)
pkg encoding/xml, method (Encoder) WriteString(string) (int, error)
We could technically remove those (we never promised them, and they were never
documented), but it could maybe break code, if people somehow knew about them.
@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Aug 13, 2013

Comment 3:

They're going away.
@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Aug 14, 2013

Comment 4:

This issue was closed by revision 85f3acd.

Status changed to Fixed.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Aug 14, 2013

Comment 5:

This issue was closed by revision 56ce83f.

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Aug 14, 2013

Comment 6:

This issue was closed by revision 54bdfc0.

@robpike robpike added fixed labels Aug 14, 2013

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.