Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/xcontext: TestStats failures with MillisToLastByte out of expected range #61268

Open
gopherbot opened this issue Jul 10, 2023 · 3 comments
Open

x/pkgsite/internal/xcontext: TestStats failures with MillisToLastByte out of expected range #61268

gopherbot opened this issue Jul 10, 2023 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/backlog

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jul 10, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`

Issue created automatically to collect these failures.

Example (log):

2023/06/29 00:02:26 Info: caching response of length 25 for /A
2023/06/29 00:02:26 Debug: serving "/A" from cache
2023/06/29 00:02:26 Info: caching response of length 25 for /A
2023/06/29 00:02:26 Debug: serving "/A" from cache
2023/06/29 00:02:27 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.59s)
    stats_test.go:72: MillisToLastByte is 587, wanted 500 +/- 50

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 10, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestStats"
2023-06-28 17:58 linux-s390x-ibm pkgsite@a9d9eedc go@03cd8a7b x/pkgsite/internal/xcontext.TestStats (log) 
2023/06/29 00:02:26 Info: caching response of length 25 for /A
2023/06/29 00:02:26 Debug: serving "/A" from cache
2023/06/29 00:02:26 Info: caching response of length 25 for /A
2023/06/29 00:02:26 Debug: serving "/A" from cache
2023/06/29 00:02:27 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.59s)
    stats_test.go:72: MillisToLastByte is 587, wanted 500 +/- 50

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2023
@bcmills bcmills changed the title x/pkgsite/internal/xcontext: TestStats failures x/pkgsite/internal/xcontext: TestStats failures with MillisToLastByte out of expected range Jul 11, 2023
@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2023

Compare #61273.

@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Jul 27, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/pkgsite/internal/xcontext" && test == "TestStats" && `MillisToLastByte is \d+, wanted \d+`
2023-07-31 22:57 linux-s390x-ibm pkgsite@0d6a9589 go@2300f7ef x/pkgsite/internal/xcontext.TestStats (log) 
2023/08/01 23:37:19 Info: caching response of length 25 for /A
2023/08/01 23:37:19 Debug: serving "/A" from cache
2023/08/01 23:37:19 Info: caching response of length 25 for /A
2023/08/01 23:37:19 Debug: serving "/A" from cache
2023/08/01 23:37:20 Error: middleware.Panic: panic!
--- FAIL: TestStats (0.71s)
    stats_test.go:72: MillisToLastByte is 706, wanted 500 +/- 50

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
Test Flakes
Status: No status
Milestone
pkgsite/backlog
Development

No branches or pull requests
3 participants
@hyangah @bcmills @gopherbot