-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Open
Labels
FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.
Milestone
Description
The gopls protocol package includes logic that would be useful for other language server implementations. There is already a go.lsp.dev/protocol package that contains significant overlap with the version of protocol included in gopls, and is depended on by several other LSP implementations for other languages that are written in Go.
Proposal would be to align gopls/internal/lsp/protocol with go.lsp.dev/protocol:
go.lsp.dev/protocolappears to be manually maintained. The auto generation logic ingopls/internal/lsp/protocolcould be moved there andgo.lsp.dev/protocolbecomes the single source of truth for all type and interface definitions.- mappers and other logic for manipulating LSP related types could also be consolidated with
go.lsp.dev/protocolas long as they are not go-specific - What's left should mainly be go-specific and could then become a "go-protocol" package that is make external
IlyasYOY
Metadata
Metadata
Assignees
Labels
FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.ToolsThis label describes issues relating to any tools in the x/tools repository.This label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.Issues related to the Go language server, gopls.