Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: archive/zip test is 15x slower with GC #6136

Closed
bradfitz opened this issue Aug 13, 2013 · 3 comments
Closed

runtime: archive/zip test is 15x slower with GC #6136

bradfitz opened this issue Aug 13, 2013 · 3 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 13, 2013

At revision a128bb95c3bd and before, GC makes this test 15x slower:

$ GOGC=off go test -v -run=TestOver65kFiles archive/zip
=== RUN TestOver65kFiles
--- PASS: TestOver65kFiles (1.98 seconds)
PASS
ok      archive/zip 2.266s

$ go test -v -run=TestOver65kFiles archive/zip
=== RUN TestOver65kFiles
--- PASS: TestOver65kFiles (1.98 seconds)
PASS
ok      archive/zip 34.124s


With GODEBUG=gctrace=1:

....
gc10708(1): 5+0+0 ms, 33 -> 16 MB 199233 -> 198896 (2034276-1835380) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10709(1): 5+0+0 ms, 33 -> 16 MB 199269 -> 198932 (2034649-1835717) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10710(1): 5+0+0 ms, 33 -> 16 MB 199305 -> 198968 (2035022-1836054) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10711(1): 5+0+0 ms, 33 -> 16 MB 199342 -> 199005 (2035396-1836391) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10712(1): 5+0+0 ms, 33 -> 16 MB 199378 -> 199041 (2035769-1836728) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10713(1): 5+0+0 ms, 33 -> 16 MB 199414 -> 199077 (2036142-1837065) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10714(1): 5+0+0 ms, 33 -> 16 MB 199452 -> 199115 (2036517-1837402) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10715(1): 5+0+0 ms, 33 -> 16 MB 199488 -> 199151 (2036890-1837739) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10716(1): 5+0+0 ms, 33 -> 16 MB 199524 -> 199187 (2037263-1838076) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10717(1): 5+0+0 ms, 33 -> 16 MB 199561 -> 199224 (2037637-1838413) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10718(1): 5+0+0 ms, 33 -> 16 MB 199597 -> 199260 (2038010-1838750) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10719(1): 5+0+0 ms, 33 -> 16 MB 199633 -> 199296 (2038383-1839087) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10720(1): 5+0+0 ms, 33 -> 16 MB 199670 -> 199333 (2038757-1839424) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10721(1): 5+0+0 ms, 33 -> 16 MB 199706 -> 199369 (2039130-1839761) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10722(1): 4+1+0 ms, 32 -> 18 MB 329730 -> 199677 (2169491-1969814) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
gc10723(1): 7+2+0 ms, 36 -> 31 MB 438544 -> 269154 (2408358-2139204) objects, 0(0)
handoff, 0(0) steal, 0/0/0 yields
--- PASS: TestOver65kFiles (34.11 seconds)


Lots of GCs.
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Aug 13, 2013

Comment 1:

Cause is allocations in issue #6138

@robpike
Copy link
Contributor

@robpike robpike commented Aug 16, 2013

Comment 2:

Is this issue ready to be closed?

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Aug 16, 2013

Comment 3:

Status changed to Retracted.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants