Skip to content

x/website: go.dev/cl redirector does not work for CL 80780043 #61363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianlancetaylor opened this issue Jul 14, 2023 · 4 comments
Closed

x/website: go.dev/cl redirector does not work for CL 80780043 #61363

ianlancetaylor opened this issue Jul 14, 2023 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Unfortunate website
Milestone
Unreleased

Comments

@ianlancetaylor
Copy link
Contributor

According to 881d693 that change was reviewed on https://golang.org/cl/80780043. However, neither that link nor https://go.dev/cl/80780043 resolves to the actual change. I'm unable to find the change on codereview.appspot.com, although other changes around that one do still exist.

The conversation remains at https://groups.google.com/g/golang-codereviews/c/6waUN-WcrRM/m/rn7OsN-pShEJ .

Not sure what happened here.
@seankhliao seankhliao changed the title website: go.dev/cl redirector does not work for CL 80780043 x/website: go.dev/cl redirector does not work for CL 80780043 Jul 14, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2023
@heschi
Copy link
Contributor

heschi commented Jul 17, 2023

cc @golang/tools-team

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 17, 2023
@jamalc
Copy link

jamalc commented Jul 20, 2023

The redirector is working as expected, it appears the target is missing the change.

@jamalc
Copy link

jamalc commented Jul 20, 2023

/cc @rsc who might have more context on https://codereview.appspot.com.

@hyangah
Copy link
Contributor

hyangah commented Jul 27, 2023

From internal discussion

Looking at the Datastore viewer that record seems to just be gone. It is possible that the CL author used Edit Issue > Delete.

@rsc started a process to copy the remaining data to prevent this type of loss in the future. Thanks!

@hyangah hyangah closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
@golang golang locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Unfortunate website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@ianlancetaylor @hyangah @gopherbot @jamalc @heschi