Skip to content

x/website: https://go.dev/security/vuln/editor#editor-specific-instructions #61633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
falco467 opened this issue Jul 28, 2023 · 3 comments
Closed
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo website

Comments

@falco467
Copy link

What is the URL of the page with the issue?

https://go.dev/security/vuln/editor#editor-specific-instructions

What did you expect to see?

The settings for VS-Code should be "ui.codelenses"

What did you see instead?

"go.diagnostic.vulncheck": "Imports", // enable the imports-based analysis by default.
"gopls": {
  "codelenses": {
    "run_govulncheck": true  // "Run govulncheck" code lens on go.mod file.
  }
}
@gopherbot gopherbot added this to the Unreleased milestone Jul 28, 2023
@seankhliao seankhliao added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Jul 29, 2023
@suzmue suzmue added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 3, 2023
@suzmue suzmue modified the milestones: Unreleased, website/later Aug 3, 2023
@suzmue suzmue removed the NeedsFix The path to resolution is known, but the work has not been done. label Aug 3, 2023
@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 4, 2023
@dr2chase
Copy link
Contributor

dr2chase commented Aug 4, 2023

@golang/tools-team
(added NeedsFix because it needs a fix and otherwise it clutters the untriaged bugs list)

@suzmue
Copy link
Contributor

suzmue commented Aug 9, 2023

These settings are passed through directly to gopls, which accepts either "ui.codelenses", or "codelenses" (but not both at the same time).

Since this section references the VS Code settings explicitly, this should be updated to match the VS Code style of `"ui.codelenses"'

@suzmue suzmue self-assigned this Aug 9, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/517776 mentions this issue: _content/security/vuln: fix VS Code settings documentation

@golang golang locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo website
Projects
None yet
Development

No branches or pull requests

5 participants