-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: panic: runtime error: index out of range [-1] in collectDepsErrors #61816
Comments
CC @golang/release for awareness, as it is the 11th hour (or 11:59pm, perhaps). Given that others have not encountered this issue, this may be rare enough not to block the 1.21.0 release. But with that said, I'm concerned about shipping a known gopls breakage with 1.21. |
Confirmed that this panic also occurs with |
I think we had an omission in https://go.dev/cl/501978: looks like we missed the case wher |
@gopherbot please consider this for backport to 1.21. It is a new Go command crash. |
Backport issue(s) opened: #61818 (for 1.21). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
I have a fix cl. I wasn't able to reproduce using the yaklang repo, but I reproduced it in a test case. |
Change https://go.dev/cl/516739 mentions this issue: |
Interesting. For me, it took nothing more than checking out the repo and running |
It could be. I just tried it on linux and was able to repro. |
Change https://go.dev/cl/519658 mentions this issue: |
…lice When we were comparing the first element of import stacks when sorting depserrors we checked if the first stack was non empty, but not the second one. Do the check for both stacks. Fixes #61818 Updates #61816 For #59905 Change-Id: Id5c11c2b1104eec93196a08c53372ee2ba97c701 Reviewed-on: https://go-review.googlesource.com/c/go/+/516739 Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Michael Matloob <matloob@golang.org> (cherry picked from commit 58447d7) Reviewed-on: https://go-review.googlesource.com/c/go/+/519658 Reviewed-by: Michael Matloob <matloob@golang.org> Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Hi is this fixed in release version of go1.21 or do we need to wait for a minor version? |
@geitir This will be included in the next minor release. |
Can confirm that this doesn't happen in the just released go 1.21.1 on my side. |
Related: #59905.
Just observed this panic while looking into golang/vscode-go#2923:
From the root directory of https://github.com/yaklang/yaklang:
Does not reproduce on 1.20.
@matloob @bcmills should this be a release blocker? It breaks gopls, and I'm not sure how many repositories it affects.
The text was updated successfully, but these errors were encountered: