-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: detect copying of Mutex #6188
Comments
This would help to resolve #17953 because if we detect copying we can have per-mutex wait list. |
@dvyukov, given that copying is likely to break a mutex anyway and we have a vet check, can't we just go ahead and do the per-mutex wait list? Why should that be blocked on having an internal copy check? |
@rsc required the runtime check for sync.Cond when I did per-Cond waitlist. But that was before the vet check. |
I have a different fix for #17953. |
Do we detect copying of sync.Mutex now? As far as I see #17953 was about a different thing. |
Forgive me if I have misunderstood something. I was just following the original thread of discussion. Brad suggested that there is a vet check which detects copying of sync.Mutex which is run as part of tests. And then you mentioned that it would still help to resolve #17953. And now, #17953 is resolved using a different fix. So, do we still need this now ? |
Depends on if we detect copying of sync.Mutex or not. If we do, then this can be considered fixed after we check if this part is still relevant:
|
The text was updated successfully, but these errors were encountered: