Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get/mod tidy panics with internal error: net token acquired but not released [1.21 backport] #61905

Closed
gopherbot opened this issue Aug 9, 2023 · 2 comments
Closed

cmd/go: go get/mod tidy panics with internal error: net token acquired but not released [1.21 backport] #61905

gopherbot opened this issue Aug 9, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.21.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #61877 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This is a regression that triggers an internal error.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Aug 9, 2023
@gopherbot gopherbot mentioned this issue Aug 9, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 9, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Aug 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 9, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/518395 mentions this issue: [release-branch.go1.21] cmd/go/internal/web: release the net token when an HTTP request fails due to CheckRedirect

@gopherbot
Copy link
Contributor Author

Closed by merging 75d8be5 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Aug 11, 2023
@mknyszek
[release-branch.go1.21] cmd/go/internal/web: release the net token wh…
75d8be5 
…en an HTTP request fails due to CheckRedirect

Updates #61877.
Fixes #61905.

Change-Id: I38c63565aaf9dc9b0c8085974521daccfbcbc790
Reviewed-on: https://go-review.googlesource.com/c/go/+/518015
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 8cb5c55)
Reviewed-on: https://go-review.googlesource.com/c/go/+/518395
@golang golang locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot