Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: OpenSearch not recognized by Firefox 116.0 #61986

Closed
Merovius opened this issue Aug 13, 2023 · 4 comments
Closed

x/pkgsite: OpenSearch not recognized by Firefox 116.0 #61986

Merovius opened this issue Aug 13, 2023 · 4 comments

Comments

@Merovius
Copy link
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/116.0

Screenshot

2023-08-13-095902_1920x1080_scrot

What did you do?

Right-click on the address bar in Firefox

What did you expect to see?

An Option to add pkg.go.dev as a search engine to Firefox.

This works with other pages (like Wikipedia or YouTube) but not with pkg.go.dev. I'm not entirely sure, but I think I actually did that not very long ago, when first setting up Firefox, but I had to reset my profile and now it doesn't. I can't imagine how it would've done that, but if my memory is correct, the timing would implicate this commit.

What did you see instead?

No such option.

@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2023
@philippgille
Copy link

I'm not entirely sure, but I think I actually did that not very long ago, when first setting up Firefox

Was that maybe via the search form, i.e.
image

@Merovius
Copy link
Contributor Author

Merovius commented Aug 13, 2023

The "Add a Keyword for this Search" behaves somewhat differently - it creates a bookmark with a search query, instead of registering a search engine. That means a) you have to put that bookmark somewhere and b) it doesn't have the same interactivity as a search engine.

So, maybe that was it? Though I don't really think so. But either way - I'd prefer pkgsite to support the actual OpenSearch integration.

@findleyr
Copy link
Contributor

Thanks for pointing this out. I agree this would be good to support. Added Help Wanted, as this looks small but not entirely trivial, and we may not get to it soon.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/539896 mentions this issue: Add OpenSearch

swills added a commit to swills/pkgsite that referenced this issue Nov 7, 2023
@golang golang locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants