Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: simple programs crash on linux/386 with go1.21 when build with -gcflags='all=-N -l' [1.21 backport] #61987

Closed
gopherbot opened this issue Aug 13, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link
Contributor

@aarzilli requested issue #61975 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go1.21, this is a regression.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 13, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 13, 2023
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 13, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/519495 mentions this issue: [release-branch.go1.21] runtime: mark traceEnabled and traceShuttingDown as no:split

@dmitshur
Copy link
Contributor

This doesn't need a 1.20 backport issue because neither CL 494180 nor CL 494183 are present in it.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 16, 2023
gopherbot pushed a commit that referenced this issue Aug 17, 2023
…own as no:split

This fixes a regression from CL 494181.
The traceEnabled function splits the stack and is being
called by reentersyscall that shouldn't call anything
that splits the stack. Same with traceShuttingDown.

For #61975
Fixes #61987

Change-Id: I5eca0ba74cfa6acb0259e8400b03c2093cd59dd1
GitHub-Last-Rev: 9e55ae9
GitHub-Pull-Request: #61981
Reviewed-on: https://go-review.googlesource.com/c/go/+/519055
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit aa5d483)
Reviewed-on: https://go-review.googlesource.com/c/go/+/519495
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 31c5a23 to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

2 participants