Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go mod download needs to support toolchain upgrades [1.21 backport] #62055

Closed
gopherbot opened this issue Aug 15, 2023 · 13 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #62054 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This is a blocker for the Go module proxy to be able to deploy Go 1.21 releases with adequate pre-release testing.

@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Aug 15, 2023
@bcmills bcmills added release-blocker CherryPickApproved Used during the release process for point releases labels Aug 15, 2023
@bcmills bcmills added this to the Go1.21.1 milestone Aug 15, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 15, 2023
@joedian
Copy link

joedian commented Aug 28, 2023

@bcmills can you please raise the cl for this?

@bcmills
Copy link
Contributor

bcmills commented Aug 28, 2023

I'm working on it today, but if it slips to Go 1.21.2 that's probably fine. (Really we just need it to be released in time for the proxy to upgrade to it while Go 1.20.x is still supported, so that we have time to test the proxy before it migrates.)

@dmitshur
Copy link
Contributor

dmitshur commented Aug 30, 2023

@bcmills The release branches are planned to be frozen today. Given the upstream issue isn't resolved yet, and you said it might be better to let it slip to Go 1.21.2 instead of holding back the Go 1.21.1 release, I plan to move this to the Go 1.21.2 milestone soon. Please comment if you think another path forward is better.

@bcmills
Copy link
Contributor

bcmills commented Aug 30, 2023

Slipping to 1.21.2 sounds good. Thanks for the heads-up.

@dmitshur dmitshur modified the milestones: Go1.21.1, Go1.21.2 Aug 30, 2023
@thanm
Copy link
Contributor

thanm commented Sep 25, 2023

Hi @bcmills looking at the schedule for Go 1.21.2 I think we are supposed to have all cherry-picks done by this Tues in order to freeze the release branch Wed and pre-announce on Thu. Will the fix for this bug make the release do you think, or should we bump to 1.21.3? Thanks.

@bcmills
Copy link
Contributor

bcmills commented Sep 25, 2023

I don't think this will be in by Tuesday, so let's bump to 1.21.3.

@thanm thanm modified the milestones: Go1.21.2, Go1.21.3 Sep 25, 2023
@thanm
Copy link
Contributor

thanm commented Sep 25, 2023

OK thanks, I've moved it.

@dmitshur dmitshur modified the milestones: Go1.21.3, Go1.21.4 Oct 10, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/537480 mentions this issue: cmd/go: allow 'go mod download' to switch toolchains if called with explicit arguments

@cherrymui
Copy link
Member

@bcmills Go 1.21.4 will be released next week, and the prebuild will start some time soon this week. As #62054 is still open and CL 537480 is not yet in, does it make sense to move this to the next minor release? Does this need to be a release blocker for the minor release? Thanks.

@bcmills
Copy link
Contributor

bcmills commented Oct 31, 2023

Should be ok to move this to the next minor release. (The main constraint is that it needs to be included in a 1.21 release before 1.20 falls out of support.)

@cherrymui cherrymui modified the milestones: Go1.21.4, Go1.21.5 Oct 31, 2023
@cherrymui
Copy link
Member

@bcmills thanks. Moved to the next milestone.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/539697 mentions this issue: [release-branch.go1.21] cmd/go: allow 'go mod download' to switch toolchains if called with explicit arguments

gopherbot pushed a commit that referenced this issue Nov 9, 2023
…lchains if called with explicit arguments

Fixes #62055.
Updates #62054.

Change-Id: I4ea24070f7d9aa4964c2f215836602068058f718
(cherry picked from CL 540779 and CL 537480)
Reviewed-on: https://go-review.googlesource.com/c/go/+/539697
Auto-Submit: Heschi Kreinick <heschi@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 4952f41 to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go release-blocker
Projects
None yet
Development

No branches or pull requests

7 participants
@dmitshur @bcmills @gopherbot @thanm @cherrymui @joedian and others