Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal compiler error: 'F': func F, startMem[b1] has different values [1.20 backport] #62056

Closed
gopherbot opened this issue Aug 15, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link
Contributor

@dr2chase requested issue #61992 to be considered for backport to the next 1.20 minor release.

@gopherbot please open the backport tracking issues. This is a use-blocking compiler bug.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 15, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 15, 2023
@gopherbot gopherbot added this to the Go1.20.8 milestone Aug 15, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/520059 mentions this issue: [release-branch.go1.20] cmd/compile: in expandCalls, move all arg marshalling into call block

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Aug 24, 2023
@cagedmantis
Copy link
Contributor

Approved as this is a serious issue without a workaround.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 24, 2023
gopherbot pushed a commit that referenced this issue Aug 24, 2023
…shalling into call block

For aggregate-typed arguments passed to a call, expandCalls
decomposed them into parts in the same block where the value
was created.  This is not necessarily the call block, and in
the case where stores are involved, can change the memory
leaving that block, and getting that right is problematic.

Instead, do all the expanding in the same block as the call,
which avoids the problems of (1) not being able to reorder
loads/stores across a block boundary to conform to memory
order and (2) (incorrectly, not) exposing the new memory to
consumers in other blocks.  Putting it all in the same block
as the call allows reordering, and the call creates its own
new memory (which is already dealt with correctly).

Fixes #62056.
Updates #61992.

Change-Id: Icc7918f0d2dd3c480cc7f496cdcd78edeca7f297
Reviewed-on: https://go-review.googlesource.com/c/go/+/519276
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit e72ecc6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/520059
@gopherbot
Copy link
Contributor Author

Closed by merging 612da32 to release-branch.go1.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

2 participants