runtime: TestCallbackInAnotherThread failures with timeout waiting for thread to exit

[gopherbot]

#!watchflakes
default <- pkg == "runtime" && test == "TestCallbackInAnotherThread" && `timeout waiting for thread to exit`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCallbackInAnotherThread (0.14s)
    syscall_windows_test.go:272: timeout waiting for thread to exit

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime" && test == "TestCallbackInAnotherThread"

2023-08-22 02:48 windows-amd64-2016 go@c140105e runtime.TestCallbackInAnotherThread (log)

--- FAIL: TestCallbackInAnotherThread (0.14s)
    syscall_windows_test.go:272: timeout waiting for thread to exit

— watchflakes

[bcmills]

It appears that this test is using a hard-coded 100ms timeout:
https://cs.opensource.google/go/go/+/master:src/runtime/syscall_windows_test.go;l=268;drc=dd78bc0564509f8c410d6467f6c4c74646bfb224

It looks like this test was added in https://go.dev/cl/114755 for #17997. Is there some reason it needs to set a timeout on this call at all?

(CC @golang/windows @golang/runtime)

[qmuntal]

Is there some reason it needs to set a timeout on this call at all?

I don't see the value on defining a WaitForSingleObject timeout instead of relying on the built-in testing timeout, IMO we could remove it and close this issue.

[mknyszek]

@qmuntal Are you planning to send a patch for this? If not, let us know! Thanks.

[qmuntal]

@qmuntal Are you planning to send a patch for this? If not, let us know! Thanks.

I will, thanks for the remaninder.

[gopherbot]

Change https://go.dev/cl/524695 mentions this issue: runtime: remove unnecessary timeout in TestCallbackInAnotherThread