Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: update unification rules [1.21 backport] #62207

Open
griesemer opened this issue Aug 22, 2023 · 4 comments
Open

spec: update unification rules [1.21 backport] #62207

griesemer opened this issue Aug 22, 2023 · 4 comments
Assignees
Labels
CherryPickApproved Used during the release process for point releases Documentation TypeInference Issue is related to generic type inference
Milestone

Comments

@griesemer
Copy link
Contributor

Reminder issue to update unification rules per fix for #62157.

@griesemer griesemer added Documentation TypeInference Issue is related to generic type inference labels Aug 22, 2023
@griesemer griesemer added this to the Go1.21.1 milestone Aug 22, 2023
@griesemer griesemer self-assigned this Aug 22, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Aug 31, 2023

@griesemer Sorry, I just noticed this issue in the Go1.21.1 milestone now. It was missed during cherry pick review earlier because it didn't have the usual CherryPickCandidate label and "[1.21 backport]" suffix (see https://go.dev/wiki/MinorReleases).

The release branches are have recently been frozen in the preparation for the upcoming minor release. Is it okay for this backport to land for Go 1.21.2 instead, or is it worth adding release-blocking label to make sure this is reviewed for Go 1.21.1? Thanks.

@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Aug 31, 2023
@dmitshur dmitshur changed the title spec: update unification rules spec: update unification rules [1.21 backport] Aug 31, 2023
@griesemer
Copy link
Contributor Author

Yes that's fine. I haven't even gotten to this yet and it won't really impact anyone for real. There's no urgency.

(The changes are in the Appendix section of the spec.)

@dmitshur dmitshur modified the milestones: Go1.21.1, Go1.21.2 Aug 31, 2023
@cherrymui cherrymui added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Sep 6, 2023
@cherrymui
Copy link
Member

Approved. This is documentation only.

@thanm
Copy link
Contributor

thanm commented Sep 25, 2023

Hi @griesemer looking at the schedule for Go 1.21.2 I think we are supposed to have all cherry-picks done by this Tues in order to freeze the release branch Wed and pre-announce on Thu. Will the fix for this bug make the release do you think, or should we bump to 1.21.3? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases Documentation TypeInference Issue is related to generic type inference
Projects
None yet
Development

No branches or pull requests

5 participants
@dmitshur @griesemer @thanm @cherrymui and others