Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: 'go test -o' may fail with ETXTBSY when running the compiled test [1.21 backport] #62222

Closed
gopherbot opened this issue Aug 22, 2023 · 2 comments
Closed

cmd/go: 'go test -o' may fail with ETXTBSY when running the compiled test [1.21 backport] #62222

gopherbot opened this issue Aug 22, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.21.1

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #62221 to be considered for backport to the next 1.21 minor release.

@gopherbot, please backport to Go 1.21. This Go command bug causes occasional test failures in TestScript/test_compile_multi_pkg, which was added in Go 1.21, and the fix is small and straightforward.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Aug 22, 2023
@gopherbot gopherbot mentioned this issue Aug 22, 2023
Closed
@gopherbot gopherbot added this to the Go1.21.1 milestone Aug 22, 2023
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Aug 22, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 22, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/522176 mentions this issue: [release-branch.go1.21] cmd/go: retry ETXTBSY errors when running test binaries

gopherbot pushed a commit that referenced this issue Aug 30, 2023
@gopherbot
[release-branch.go1.21] cmd/go: retry ETXTBSY errors when running tes…
0a95821 
…t binaries

An ETXTBSY error when starting a test binary is almost certainly
caused by the race reported in #22315. That race will resolve quickly
on its own, so we should just retry the command instead of reporting a
spurious failure.

Fixes #62222.
Updates #62221.

Change-Id: I408f3eaa7ab5d7efbc7a2b1c8bea3dbc459fc794
Reviewed-on: https://go-review.googlesource.com/c/go/+/522015
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit 4dc2564)
Reviewed-on: https://go-review.googlesource.com/c/go/+/522176
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging 0a95821 to release-branch.go1.21.

@golang golang locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.21.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot