Skip to content

x/website: blog/comparable: bad punctuation #62310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willfaught opened this issue Aug 27, 2023 · 4 comments
Closed

x/website: blog/comparable: bad punctuation #62310

willfaught opened this issue Aug 27, 2023 · 4 comments

Comments

@willfaught
Copy link
Contributor

willfaught commented Aug 27, 2023

https://go.dev/blog/comparable

introduced with Go 1.18. comparable is an interface type

Period after "1.18".

@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2023
@willfaught
Copy link
Contributor Author

Also:

But this is ok: we do like to know that

"ok" should be OK or okay.

@findleyr
Copy link
Member

CC @griesemer

I think the punctuation is intended and correct: comparable starts the next sentence, and since it is a Go identifier it is correct not to change its capitalization.

"ok" should be OK or okay.

Sure, I think that's right. But IMO this is benign, and it's OK (or okay :)) for the blog to have some typo's / misspelling / grammar issues. I suspect there are more! With that said, I defer to @griesemer as to whether or not this particular typo should be fixed.

@griesemer
Copy link
Contributor

I agree with @findleyr . This is not worth the churn. Closing.

@willfaught
Copy link
Contributor Author

I think the punctuation is intended and correct: comparable starts the next sentence, and since it is a Go identifier it is correct not to change its capitalization.

I see it now, I agree.

@golang golang locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants