Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: may-start-trybots only applies to one's own CLs #62332

Closed
heschi opened this issue Aug 28, 2023 · 2 comments
Closed

x/build: may-start-trybots only applies to one's own CLs #62332

heschi opened this issue Aug 28, 2023 · 2 comments
Assignees
@prattmic
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Aug 28, 2023

In LUCI, may-start-trybots only grants permission to trigger a presubmit run on a CL you authored yourself. (Approvers can still trigger presubmits on any CL.)

This makes community members less able to shepherd CLs and therefore slows down the Go project as a whole. We want to fix this in LUCI (see https://crbug.com/1443582), but if it's causing enough trouble in the meantime we can look into workarounds. If that's important to you, please comment on or react to this issue.

cc @golang/release
@heschi heschi added Builders x/build issues (builders, bots, dashboards) NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 28, 2023
@heschi heschi added this to the Unreleased milestone Aug 28, 2023
@mateusz834 mateusz834 mentioned this issue Oct 5, 2023
Closed
@prattmic prattmic self-assigned this Jan 26, 2024
@prattmic prattmic added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Jan 26, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/560435 mentions this issue: main.star: allow non-owner testing by may-start-trybots users

@dmitshur dmitshur moved this to In Progress in Go Release Feb 1, 2024
gopherbot pushed a commit to golang/build that referenced this issue Feb 1, 2024
@prattmic @gopherbot
main.star: allow non-owner testing by may-start-trybots users
220254a 
allow_non_owner_dry_runner was added to LUCI in
https://crrev.com/c/5241102. This option allows dry runners (i.e.,
may-start-trybots users) to trigger CQ+1 test runs on any CL, including
those that they do not own.

For golang/go#62332.

Change-Id: Id25b12c973707c74c07eaac04ae077bb1a256c6e
Reviewed-on: https://go-review.googlesource.com/c/build/+/560435
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
TryBot-Bypass: Michael Pratt <mpratt@google.com>
@prattmic
Copy link
Member

prattmic commented Feb 1, 2024

This should be fixed now. Felix graciously tested triggering tests on https://go.dev/cl/554615.

@prattmic prattmic closed this as completed Feb 1, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prattmic prattmic

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@prattmic @gopherbot @heschi