Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestLockRankGenerated failures #62334

Closed
gopherbot opened this issue Aug 28, 2023 · 4 comments
Closed

runtime: TestLockRankGenerated failures #62334

gopherbot opened this issue Aug 28, 2023 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Aug 28, 2023 •
edited by bcmills
Loading 

#!watchflakes
default <- pkg == "runtime" && test == "TestLockRankGenerated" && date <= "2023-08-29"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestLockRankGenerated (0.25s)
    lockrank_test.go:20: exit status 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 28, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime" && test == "TestLockRankGenerated"
2023-08-28 18:26 linux-loong64-3a5000 go@7b166602 runtime.TestLockRankGenerated (log) 
--- FAIL: TestLockRankGenerated (0.25s)
    lockrank_test.go:20: exit status 1

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 28, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/524056 mentions this issue: runtime: log stderr in TestLockRankGenerated on failure

@bcmills bcmills added this to the Backlog milestone Aug 29, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2023

I'm guessing this is some loong64-specific runtime or toolchain bug, but without the stderr from the command it's really hard to say. First step is probably https://go.dev/wiki/CodeReviewComments#useful-test-failures.

gopherbot pushed a commit that referenced this issue Aug 29, 2023
@gopherbot
runtime: log stderr in TestLockRankGenerated on failure
fcb75c8 
For #62334.

Change-Id: I6d93dacc914590ef9c5a034dd4633466ec0bde8d
Reviewed-on: https://go-review.googlesource.com/c/go/+/524056
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
@bcmills
Copy link
Contributor

bcmills commented Aug 29, 2023

I suspect that with logging this will dedup to one of the other open loong64 issues, so closing this issue.

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2023
@golang golang locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot