Skip to content

x/tools/internal/refactor/inline: Test failures with no such tool "compile" #62351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 29, 2023 · 4 comments
Closed

x/tools/internal/refactor/inline: Test failures with no such tool "compile" #62351

gopherbot opened this issue Aug 29, 2023 · 4 comments
Assignees
@adonovan
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Aug 29, 2023 •
edited by bcmills
Loading 

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/refactor/inline" && test == "Test" && `no such tool "compile"`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: Test (0.00s)
    --- FAIL: Test/err-shadow-pkg.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-err.txtar (0.10s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-shadow-builtin.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-basic.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/dotimport.txtar (0.08s)
...
    --- FAIL: Test/comments.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-reduce.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-literal.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/internal.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/revdotimport.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
...
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/crosspkg.txtar (0.56s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/exprstmt.txtar (0.08s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/import-shadow.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-unexported.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
exitcode=1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 29, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/refactor/inline" && test == "Test"
2023-08-29 15:44 android-386-emu tools@edda81f8 go@612da32f x/tools/internal/refactor/inline.Test (log) 
--- FAIL: Test (0.00s)
    --- FAIL: Test/err-shadow-pkg.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-err.txtar (0.10s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-shadow-builtin.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-basic.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/dotimport.txtar (0.08s)
...
    --- FAIL: Test/comments.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-reduce.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-literal.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/internal.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/revdotimport.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
...
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/crosspkg.txtar (0.56s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/exprstmt.txtar (0.08s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/import-shadow.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-unexported.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
exitcode=1
2023-08-29 15:44 android-amd64-emu tools@edda81f8 go@612da32f x/tools/internal/refactor/inline.Test (log) 
--- FAIL: Test (0.00s)
    --- FAIL: Test/err-shadow-pkg.txtar (0.10s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-err.txtar (0.12s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/revdotimport.txtar (0.04s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/method.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/n-ary.txtar (0.09s)
...
    --- FAIL: Test/internal.txtar (0.04s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/import-shadow.txtar (0.03s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/exprstmt.txtar (0.04s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-unexported.txtar (0.12s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-shadow-builtin.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
...
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-reduce.txtar (0.08s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/comments.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-literal.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/crosspkg.txtar (0.46s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
exitcode=1

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Aug 29, 2023
@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/internal/refactor/inline" && test == "Test"
2023-08-29 16:29 android-386-emu tools@5e8d21aa go@612da32f x/tools/internal/refactor/inline.Test (log) 
--- FAIL: Test (0.01s)
    --- FAIL: Test/err-shadow-pkg.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-err.txtar (0.08s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-shadow-builtin.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-basic.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/dotimport.txtar (0.05s)
...
    --- FAIL: Test/comments.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-reduce.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-literal.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/revdotimport.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/crosspkg.txtar (0.44s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
...
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/internal.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/import-shadow.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/exprstmt.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-unexported.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
exitcode=1
2023-08-29 16:29 android-amd64-emu tools@5e8d21aa go@612da32f x/tools/internal/refactor/inline.Test (log) 
--- FAIL: Test (0.01s)
    --- FAIL: Test/err-shadow-pkg.txtar (0.04s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-shadow-builtin.txtar (0.04s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-err.txtar (0.12s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-basic.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/dotimport.txtar (0.07s)
...
    --- FAIL: Test/comments.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-reduce.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/basic-literal.txtar (0.08s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/internal.txtar (0.09s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/revdotimport.txtar (0.06s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
...
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/crosspkg.txtar (0.57s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/exprstmt.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/err-unexported.txtar (0.05s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
    --- FAIL: Test/import-shadow.txtar (0.07s)
        inline_test.go:60: Load: err: exit status 2: stderr: go: no such tool "compile"
exitcode=1

— watchflakes

@hyangah
Copy link
Contributor

hyangah commented Aug 29, 2023

cc @adonovan Looks like those tests need testenv.NeedsTool.

@bcmills bcmills changed the title x/tools/internal/refactor/inline: Test failures x/tools/internal/refactor/inline: Test failures with no such tool "compile" Aug 29, 2023
@adonovan adonovan self-assigned this Aug 29, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/524057 mentions this issue: internal/refactor/inline: NeedGoPackages in test

@golang golang locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@hyangah @adonovan @gopherbot