You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree that this code doesn't make sense, but what I don't know is what it is supposed to do. When this code was introduced in https://go.dev/cl/7400055, it made sense because ifi was passed to newAddr. That was changed in https://go.dev/cl/37892, because newAddr didn't use that parameter. But newAddr used to use the parameter; that part changed in (I think) https://go.dev/cl/11352. So I guess that we could just stop setting ifi in the loop today. But I'd rather that somebody who knows what this code is doing double-check that it is doing what it is supposed to do.