Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: comment handling introduced in 1.21.1 breaks valid scripts [1.21 backport] #63208

Closed
gopherbot opened this issue Sep 25, 2023 · 1 comment
Closed

html/template: comment handling introduced in 1.21.1 breaks valid scripts [1.21 backport] #63208

gopherbot opened this issue Sep 25, 2023 · 1 comment
Labels
Security WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.21.11

Comments

@gopherbot
Copy link
Contributor

@rolandshoemaker requested issue #63183 to be considered for backport to the next 1.21 minor release.

Bah, this is due to a misreading of the specification by myself, I misread SingleLineHTMLCloseComment and HTMLCloseComment, which allows SingleLineDelimitedCommentSequence before the --> token.

Slightly confusingly this means you can have /* comment */ --> more comment but not real text --> comment.

This is an unexpected breaking change, so we should backport the fix.

@gopherbot please open backport issues.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security labels Sep 25, 2023
@gopherbot gopherbot mentioned this issue Sep 25, 2023
Open
@gopherbot gopherbot added this to the Go1.21.2 milestone Sep 25, 2023
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Oct 4, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Oct 4, 2023
@gopherbot gopherbot modified the milestones: Go1.21.2, Go1.21.3, Go1.21.4 Oct 5, 2023
@gopherbot gopherbot modified the milestones: Go1.21.4, Go1.21.5 Nov 7, 2023
@heschi heschi added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Nov 7, 2023
@gopherbot gopherbot modified the milestones: Go1.21.5, Go1.21.6 Dec 5, 2023
@gopherbot gopherbot modified the milestones: Go1.21.6, Go1.21.7 Jan 9, 2024
@gopherbot gopherbot modified the milestones: Go1.21.7, Go1.21.8 Feb 6, 2024
@gopherbot gopherbot modified the milestones: Go1.21.8, Go1.21.9 Mar 5, 2024
@gopherbot gopherbot modified the milestones: Go1.21.9, Go1.21.10 Apr 3, 2024
@gopherbot gopherbot modified the milestones: Go1.21.10, Go1.21.11 May 7, 2024
@gopherbot
Copy link
Contributor Author

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@gopherbot gopherbot closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2024
@dmitshur dmitshur removed the CherryPickApproved Used during the release process for point releases label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Security WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.21.11
Development

No branches or pull requests
4 participants
@prattmic @dmitshur @gopherbot @heschi