Skip to content

x/website: Go keywords syntax is not readable with Dark mode and Syntax Highlighting turned on #63229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manish-Giri opened this issue Sep 26, 2023 · 3 comments
Closed

x/website: Go keywords syntax is not readable with Dark mode and Syntax Highlighting turned on #63229

Manish-Giri opened this issue Sep 26, 2023 · 3 comments
Assignees
@suzmue
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
website/backlog

Comments

@Manish-Giri
Copy link

What is the URL of the page with the issue?

https://go.dev/tour/moretypes/9

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Edg/117.0.2045.36

Screenshot

image

None of the bool values are readable.

What did you do?

  1. Visit the Tour of Go website.
  2. Turn on dark mode on the page (top right).
  3. Turn on syntax highlighting for the editor (top right).

What did you expect to see?

Code should be readable.

What did you see instead?

Code is not readable.
@gopherbot gopherbot added this to the Unreleased milestone Sep 26, 2023
@seankhliao seankhliao changed the title x/pkgsite: Go keywords syntax is not readable with Dark mode and Syntax Highlighting turned on x/website: Go keywords syntax is not readable with Dark mode and Syntax Highlighting turned on Sep 26, 2023
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 26, 2023
@thanm
Copy link
Contributor

thanm commented Sep 26, 2023

@golang/tools-team

@suzmue suzmue modified the milestones: Unreleased, website/backlog Sep 26, 2023
@suzmue
Copy link
Contributor

suzmue commented Sep 26, 2023

go.dev shoots for a color contrast of 4.5:1 or greater for all text.

The booleans on this page have a ratio of 1.02:1
Screenshot 2023-09-26 at 10 09 21 AM

Comments also have a low contrast ratio of 2.42 in dark mode, https://go.dev/tour/moretypes/5:
Screenshot 2023-09-26 at 10 09 52 AM

@suzmue suzmue self-assigned this Sep 26, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/531215 mentions this issue: _content/tour: improve color contrast for dark theme

willpoint pushed a commit to orijtech/website that referenced this issue Oct 17, 2023
@suzmue @willpoint
_content/tour: improve color contrast for dark theme
658cb50 
Updated the color to improve the color contrast when using dark
mode. More or less tried to pick a lighter color of the light
mode color.

Color contrast changes:
- cm.atom: 1.02 -> 6.26
- cm.comment: 2.42 -> 7.6

Fixes golang/go#63229

Change-Id: Ie6257b71d32d8cccf11025e74108e80ae4f9b36d
Reviewed-on: https://go-review.googlesource.com/c/website/+/531215
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@suzmue suzmue

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
5 participants
@suzmue @gopherbot @seankhliao @Manish-Giri @thanm