x/website: Cursor color on the Tour of Go editor in dark mode is not readable #63313
Assignees
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
pkgsite
website
Milestone
Comments
AlexanderYastrebov
added a commit
to AlexanderYastrebov/golang-website
that referenced
this issue
Sep 30, 2023
Add styles for dark theme cursor and selection. Cursor color set equal to the foreground color. Focused selection color set to the complement color of the background color and inactive selection is the lighter tint of it. Fixes golang/go#63313
|
Created golang/website#253 to fix cursor and selection colors.
|
|
Change https://go.dev/cl/531856 mentions this issue: |
hyangah
added
the
NeedsFix
willpoint
pushed a commit
to orijtech/website
that referenced
this issue
Oct 17, 2023
Add styles for dark theme cursor and selection. Cursor color set equal to the foreground color. Focused selection color set to the complement color of the background color and inactive selection is the lighter tint of it. Fixes golang/go#63313 Change-Id: If9702f45262eea330d42ec0fd9717b36da026540 GitHub-Last-Rev: 1545bba GitHub-Pull-Request: golang#253 Reviewed-on: https://go-review.googlesource.com/c/website/+/531856 TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Suzy Mueller <suzmue@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Suzy Mueller <suzmue@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the URL of the page with the issue?
https://go.dev/tour/welcome/1
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36
Screenshot
Notice the barely-visible black cursor at the end of the
fmt.Println()statement. It looks like the color was selected for the light mode and never adjusted for dark mode. Below is the same cursor in light mode.What did you do?
What did you expect to see?
A clearly visible cursor.
What did you see instead?
See screenshot above.
The text was updated successfully, but these errors were encountered: