Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add LUCI plan9-arm builder #63601

Closed
0intro opened this issue Oct 17, 2023 · 10 comments
Closed

x/build: add LUCI plan9-arm builder #63601

0intro opened this issue Oct 17, 2023 · 10 comments
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Plan9
Milestone

Comments

@0intro
Copy link
Member

0intro commented Oct 17, 2023

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Oct 17, 2023
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 19, 2023
@cagedmantis
Copy link
Contributor

@golang/release

@cagedmantis cagedmantis moved this to In Progress in Go Release Oct 20, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/536196 mentions this issue: main.star: add plan9-{386, amd64, arm} builders

gopherbot pushed a commit to golang/build that referenced this issue Oct 25, 2023
For golang/go#63599
For golang/go#63600
For golang/go#63601

Change-Id: I804b903615861667cc88c70b25296871788ef5ed
Reviewed-on: https://go-review.googlesource.com/c/build/+/536196
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
@cagedmantis
Copy link
Contributor

Here is the certificate: plan9-arm-1698265912.cert.txt

@dmitshur dmitshur moved this from In Progress to Planned in Go Release Dec 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/558517 mentions this issue: main.star: fix cipd_platform value for GOHOSTARCH=arm

gopherbot pushed a commit to golang/build that referenced this issue Jan 26, 2024
Handle another way in which cipd_platform is slightly
different from Go's GOHOSTOS and GOHOSTARCH values.

For golang/go#65241.
For golang/go#63698.
For golang/go#63601.

Change-Id: I3caad897b821208939b8b411663ba417c4c21df7
Reviewed-on: https://go-review.googlesource.com/c/build/+/558517
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur dmitshur moved this from Planned to In Progress in Go Release Aug 24, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9 arch-arm Issues solely affecting the 32-bit arm architecture. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 24, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/608155 mentions this issue: main.star: unset known issues for plan9/{386,arm} builder types

@dmitshur
Copy link
Contributor

dmitshur commented Sep 4, 2024

@0intro https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-plan9-arm reports that the plan9-arm builder is offline.

@0intro
Copy link
Member Author

0intro commented Sep 4, 2024

@millerresearch

@dmitshur
Copy link
Contributor

dmitshur commented Sep 5, 2024

Thanks, the builder is back and passing again.

@millerresearch, @0intro Have you had a chance to see CL 608155? Shall we proceed with it now? Thanks.

@millerresearch
Copy link
Contributor

@millerresearch, @0intro Have you had a chance to see CL 608155? Shall we proceed with it now? Thanks.

Yes, that's fine with me -- I've given it a +1.

gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2024
These builders have reached a point where they're considered added.

Fixes golang/go#63599.
Fixes golang/go#63601.

Change-Id: I37bcd2905b0b39b639828c3e3de9f2d0ebdbc994
Reviewed-on: https://go-review.googlesource.com/c/build/+/608155
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: David du Colombier <0intro@gmail.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Richard Miller <millerresearch@gmail.com>
@gopherbot
Copy link
Contributor

Closed by merging CL 608155 (commit golang/build@8dd23da) to luci-config.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-Plan9
Projects
Status: Done
Development

No branches or pull requests

5 participants