Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestG0StackOverflow fails on OpenBSD #63794

Closed
mauri870 opened this issue Oct 27, 2023 · 4 comments
Closed

runtime: TestG0StackOverflow fails on OpenBSD #63794

mauri870 opened this issue Oct 27, 2023 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Milestone

Comments

@mauri870
Copy link
Member

https://build.golang.org/log/597e50ab4c5b1e58fa8aa5a05676ecac63aa0668

Started seeing this happening on builds for different CLs:

crash_test.go:805: === RUN   TestG0StackOverflow
        SIGSEGV: segmentation violation
        PC=0x477d50 m=0 sigcode=2 addr=0x477d50
        
        goroutine 0 [idle]:
        runtime.switchToCrashStack0()
        	/tmp/workdir/go/src/runtime/asm_amd64.s:559 +0x30 fp=0xb9e530 sp=0xb9e520 pc=0x477d50
        
        goroutine 6 [running]:
        runtime.systemstack_switch()
        	/tmp/workdir/go/src/runtime/asm_amd64.s:474 +0x8 fp=0xc000058670 sp=0xc000058660 pc=0x477c68
        runtime.G0StackOverflow(...)
        	/tmp/workdir/go/src/runtime/export_test.go:691
        runtime_test.TestG0StackOverflow(0xc000164340)
        	/tmp/workdir/go/src/runtime/crash_test.go:824 +0x365 fp=0xc000058770 sp=0xc000058670 pc=0x6fb925
        testing.tRunner(0xc000164340, 0x889ff0)
        	/tmp/workdir/go/src/testing/testing.go:1682 +0xfb fp=0xc0000587c0 sp=0xc000058770 pc=0x502b3b
        testing.(*T).Run.gowrap1()
        	/tmp/workdir/go/src/testing/testing.go:1735 +0x25 fp=0xc0000587e0 sp=0xc0000587c0 pc=0x503aa5
        runtime.goexit({})
        	/tmp/workdir/go/src/runtime/asm_amd64.s:1694 +0x1 fp=0xc0000587e8 sp=0xc0000587e0 pc=0x479ca1
        created by testing.(*T).Run in goroutine 1
        	/tmp/workdir/go/src/testing/testing.go:1735 +0x390
@mauri870 mauri870 added OS-OpenBSD NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. compiler/runtime Issues related to the Go compiler and/or runtime. labels Oct 27, 2023
@mauri870
Copy link
Member Author

attn @golang/openbsd

@mauri870
Copy link
Member Author

Should be fixed once CL 537975 is merged

@mauri870 mauri870 added this to the Unreleased milestone Oct 29, 2023
@4a6f656c
Copy link
Contributor

CL#538457 makes this work on OpenBSD.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/538457 mentions this issue: runtime: allocate crash stack via stackalloc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-OpenBSD
Projects
None yet
Development

No branches or pull requests

3 participants