Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: make C.malloc(0) return non-nil #6390

Closed
rsc opened this issue Sep 15, 2013 · 2 comments

Comments

@rsc
Copy link
Contributor

commented Sep 15, 2013

Now that C.malloc is really C.__Cmalloc where __Cmalloc is our wrapper, we should make
the wrapper change 0 to 1 before calling the standard malloc. The standard malloc(0) can
return NULL, which will make the wrapper crash the program.

Thanks to Ralph Corderoy for the reminder.
(See issue #3403.)
@gopherbot

This comment has been minimized.

Copy link

commented Sep 15, 2013

Comment 1 by ralph.corderoy:

Perhaps only malloc(1) if malloc(0) returns NULL in case there's special handling of 0
that returns non-NULL and is less overhead, e.g. descriptor only.
    if(p == NULL && (n || (p = malloc(1)) == NULL))
        runtime_throw("runtime: C malloc failed");
@rsc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2013

Comment 2:

This issue was closed by revision 647eaed.

Status changed to Fixed.

@rsc rsc added fixed labels Sep 16, 2013

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.