Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: switch to using go/version once we can use it in the compiler #63974

Closed
griesemer opened this issue Nov 7, 2023 · 2 comments
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@griesemer
Copy link
Contributor

Reminder issue to remove version parsing and version data structures in the type checkers in favor of go/version, once the package is available for bootstrapping the compiler.

Tentatively marking for 1.23 (but it may be 1.24).

@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2023
@griesemer griesemer added this to the Go1.23 milestone Nov 7, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541296 mentions this issue: cmd/compile: update types2.Info.FileVersions API to match go/types

gopherbot pushed a commit that referenced this issue Nov 10, 2023
This CL changes the FileVersions map to map to version strings
rather than Version structs, for use with the new go/versions
package.

Adjust the cmd/dist bootstrap package list to include go/version.

Adjust the compiler's noder to work with the new API.

For #62605.
For #63974.

Change-Id: I191a7015ba3fb61c646e9f9d3c3dbafc9653ccb5
Reviewed-on: https://go-review.googlesource.com/c/go/+/541296
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/541395 mentions this issue: go/types, types2: remove local version processing in favor of go/version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants