Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/list_pkgconfig_error failures #64017

Closed
bcmills opened this issue Nov 8, 2023 · 4 comments
Closed

cmd/go: TestScript/list_pkgconfig_error failures #64017

bcmills opened this issue Nov 8, 2023 · 4 comments
Labels
GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Nov 8, 2023

#!watchflakes
post <- pkg == "cmd/go" && `FAIL: testdata/script/list_pkgconfig_error.txt` && date < "2023-10-20"
@bcmills bcmills closed this as completed Nov 8, 2023
@bcmills bcmills added GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 8, 2023
@bcmills
Copy link
Member Author

bcmills commented Nov 8, 2023

(Fixed by https://go.dev/cl/536195; just filing an issue for filtering purposes.)

@bcmills bcmills added this to the Go1.22 milestone Nov 8, 2023
@bcmills
Copy link
Member Author

bcmills commented Nov 8, 2023

@cherrymui, any idea why the logs in #64021 (comment) were not matched to this issue?

The pattern in effect at the time was

post <- pkg == "cmd/go" && test == "TestScript/list_pkgconfig_error" && date < "2023-10-20"

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && `FAIL: testdata/script/list_pkgconfig_error.txt` && date < "2023-10-20"
2023-10-18 14:06 openbsd-arm64-jsing go@045ce51b cmd/go.TestScript (log)
vcs-test.golang.org rerouted to http://127.0.0.1:38080
https://vcs-test.golang.org rerouted to https://127.0.0.1:12215
go test proxy running at GOPROXY=http://127.0.0.1:15201/mod
--- FAIL: TestScript (2.72s)
    --- FAIL: TestScript/list_pkgconfig_error (3.17s)
        script_test.go:132: 2023-10-15T19:22:43Z
        script_test.go:134: $WORK=/home/gopher/build/tmp/cmd-go-test-2207993964/tmpdir1948278908/list_pkgconfig_error611240806
        script_test.go:156: 
            > [!cgo] skip 'test verifies cgo pkg-config errors'
            [condition not met]
            > [!exec:pkg-config] skip 'test requires pkg-config tool'
            [condition not met]
            > ! go list -export .
            [stdout]
            example
            [stderr]
            go build example:
            # pkg-config --cflags  -- libnot-a-valid-cgo-library
            Package libnot-a-valid-cgo-library was not found in the pkg-config search path
            [exit status 1]
            > stderr '^go build example:\n# pkg-config (.*\n)+Package .* not found$'
        script_test.go:156: FAIL: testdata/script/list_pkgconfig_error.txt:5: stderr '^go build example:\n# pkg-config (.*\n)+Package .* not found$': no match for `(?m)^go build example:\n# pkg-config (.*\n)+Package .* not found$` in stderr
2023-10-18 14:46 linux-riscv64-unmatched go@4bf4c7d2 cmd/go.TestScript (log)
vcs-test.golang.org rerouted to http://127.0.0.1:34277
https://vcs-test.golang.org rerouted to https://127.0.0.1:39867
go test proxy running at GOPROXY=http://127.0.0.1:45153/mod
2023/10/21 15:58:29 http: TLS handshake error from 127.0.0.1:48998: read tcp 127.0.0.1:39867->127.0.0.1:48998: read: connection reset by peer
--- FAIL: TestScript (0.38s)
    --- FAIL: TestScript/list_pkgconfig_error (1.14s)
        script_test.go:132: 2023-10-21T15:58:38Z
        script_test.go:134: $WORK=/tmp/workdir-host-linux-riscv64-unmatched/tmp/cmd-go-test-3320461688/tmpdir691228765/list_pkgconfig_error2382318427
        script_test.go:156: 
            > [!cgo] skip 'test verifies cgo pkg-config errors'
            [condition not met]
            > [!exec:pkg-config] skip 'test requires pkg-config tool'
            [condition not met]
            > ! go list -export .
            [stdout]
            example
            [stderr]
            go build example:
            # pkg-config --cflags  -- libnot-a-valid-cgo-library
            Package libnot-a-valid-cgo-library was not found in the pkg-config search path.
            Perhaps you should add the directory containing `libnot-a-valid-cgo-library.pc'
            to the PKG_CONFIG_PATH environment variable
            No package 'libnot-a-valid-cgo-library' found
            [exit status 1]
            > stderr '^go build example:\n# pkg-config (.*\n)+Package .* not found$'
        script_test.go:156: FAIL: testdata/script/list_pkgconfig_error.txt:5: stderr '^go build example:\n# pkg-config (.*\n)+Package .* not found$': no match for `(?m)^go build example:\n# pkg-config (.*\n)+Package .* not found$` in stderr

watchflakes

@cherrymui
Copy link
Member

I think test doesn't include subtest. On #64021 it has test == "TestScript". We might be able to update the parser to include include subtest. The JSON logs from LUCI might make it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand cmd/go Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Status: Done
Development

No branches or pull requests

3 participants