Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path/filepath: Clean removes ending slash for volume on Windows in Go 1.21.4 [1.20 backport] #64040

Closed
gopherbot opened this issue Nov 9, 2023 · 3 comments
Closed

path/filepath: Clean removes ending slash for volume on Windows in Go 1.21.4 [1.20 backport] #64040

gopherbot opened this issue Nov 9, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Milestone
Go1.20.12

Comments

@gopherbot
Copy link

@bcmills requested issue #64028 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.21 and maybe 1.20. This appears to be a regression introduced in a security release.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 9, 2023
@gopherbot gopherbot mentioned this issue Nov 9, 2023
Closed
@bcmills bcmills modified the milestones: Go1.21.5, Go1.20.12 Nov 9, 2023
thaJeztah pushed a commit to thaJeztah/go that referenced this issue Nov 13, 2023
@neild @thaJeztah
[release-branch.go1.20] path/filepath: consider \\?\c: as a volume on…
9eb4f47 
… Windows

While fixing several bugs in path handling on Windows,
beginning with \\?\.

Prior to #540277, VolumeName considered the first path component
after the \\?\ prefix to be part of the volume name.
After, it considered only the \\? prefix to be the volume name.

Restore the previous behavior.

Fixes golang#64040
Updates golang#64028

Change-Id: I6523789e61776342800bd607fb3f29d496257e68
Reviewed-on: https://go-review.googlesource.com/c/go/+/541175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
(cherry picked from commit eda42f7)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah pushed a commit to thaJeztah/go that referenced this issue Nov 13, 2023
@neild @thaJeztah
[release-branch.go1.20] path/filepath: consider \\?\c: as a volume on…
e10b05d 
… Windows

While fixing several bugs in path handling on Windows,
beginning with \\?\.

Prior to #540277, VolumeName considered the first path component
after the \\?\ prefix to be part of the volume name.
After, it considered only the \\? prefix to be the volume name.

Restore the previous behavior.

Fixes golang#64040
Updates golang#64028

Change-Id: I6523789e61776342800bd607fb3f29d496257e68
Reviewed-on: https://go-review.googlesource.com/c/go/+/541175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
(cherry picked from commit eda42f7)
@thaJeztah thaJeztah mentioned this issue Nov 13, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/541520 mentions this issue: [release-branch.go1.20] path/filepath: consider \\?\c: as a volume on Windows

@gopherbot

This comment was marked as duplicate.

Sign in to view
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Nov 15, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 15, 2023
@gopherbot
Copy link
Author

Closed by merging 1b59b01 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Nov 28, 2023
@neild @gopherbot
[release-branch.go1.20] path/filepath: consider \\?\c: as a volume on…
1b59b01 
… Windows

While fixing several bugs in path handling on Windows,
beginning with \\?\.

Prior to #540277, VolumeName considered the first path component
after the \\?\ prefix to be part of the volume name.
After, it considered only the \\? prefix to be the volume name.

Restore the previous behavior.

For #64028.
Fixes #64040.

Change-Id: I6523789e61776342800bd607fb3f29d496257e68
Reviewed-on: https://go-review.googlesource.com/c/go/+/541175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
(cherry picked from commit eda42f7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/541520
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
rcrozean pushed a commit to rcrozean/go that referenced this issue Dec 7, 2023
@neild @rcrozean
path/filepath: consider \\?\c: as a volume on Windows
35ddbd5 
While fixing several bugs in path handling on Windows,
beginning with \\?\.

Prior to #540277, VolumeName considered the first path component
after the \\?\ prefix to be part of the volume name.
After, it considered only the \\? prefix to be the volume name.

Restore the previous behavior.

For golang#64028.
Fixes golang#64040.

Change-Id: I6523789e61776342800bd607fb3f29d496257e68
Reviewed-on: https://go-review.googlesource.com/c/go/+/541175
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
(cherry picked from commit eda42f7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/541520
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Projects
None yet
Milestone
Go1.20.12
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi