x/tools/gopls: Expect the Implement code action to add the receiver name by default.

[tttoad]

I think adding default variable names is helpful in most cases.
If it passes, I will implement this feature.

What did you do?

Call Implement code action

What did you expect to see?

func (l *Logger) DPanicCtx(ctx context.Context, args ...interface{}) {
	panic("unimplemented")
}

// DPanicfCtx implements LoggerCtx.
func (l *Logger) DPanicfCtx(ctx context.Context, template string, args ...interface{}) {
	panic("unimplemented")
}

// DPaniclnCtx implements LoggerCtx.
func (l *Logger) DPaniclnCtx(ctx context.Context, args ...interface{}) {
	panic("unimplemented")
}

What did you see instead?

func (*Logger) DPanicCtx(ctx context.Context, args ...interface{}) {
	panic("unimplemented")
}

// DPanicfCtx implements LoggerCtx.
func (*Logger) DPanicfCtx(ctx context.Context, template string, args ...interface{}) {
	panic("unimplemented")
}

// DPaniclnCtx implements LoggerCtx.
func (*Logger) DPaniclnCtx(ctx context.Context, args ...interface{}) {
	panic("unimplemented")
}

[findleyr]

I suppose so. At the very least, I think it's inconsistent to add names for other parameters but not the receiver parameter.

We will discuss this in our weekly triage meeting. I think this is worth doing, but want to see if the rest of the team agrees. If anyone reading this has an opinion one way or the other, please let us know.

[tttoad]

@findleyr Any luck with the discussion?

[findleyr]

Sorry, yes we discussed and agree it makes sense.

[gopherbot]

Change https://go.dev/cl/544916 mentions this issue: gopls/stub: the implement code action to add the receiver name by default