-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: incorrectly suggests internal/singleflight completion #64083
Labels
gopls/imports
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
findleyr
added
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
labels
Nov 12, 2023
$ go list -deps ./... | grep singleflight
internal/singleflight
golang.org/x/sync/singleflight gopls -vv -rpc.trace
nvim lsp log
recording: recording.mp4 |
This can wait until v0.16.0, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
gopls/imports
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Reported from @seankhliao in slack: gopls reported
internal/singleflight
(from std) as a completion candidate, while not working in std.Though related to unimported completion of standard library candidates, I think this is distinct from #63767. Specifically, I am suspicious of the 'fast path' unimported completion which looks at packages already in the import graph:
https://cs.opensource.google/go/x/tools/+/master:gopls/internal/lsp/source/completion/completion.go;l=1695;drc=7f23bc81dc216f83d56b5256abc053109bf5c58b
@seankhliao can you
go list -deps ./... | grep singleflight
to confirm that this package is in your import graph?The text was updated successfully, but these errors were encountered: