Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iter: add GOEXPERIMENT=rangefunc-limited version [freeze exception] #64277

Closed
rsc opened this issue Nov 20, 2023 · 5 comments
Closed

iter: add GOEXPERIMENT=rangefunc-limited version [freeze exception] #64277

rsc opened this issue Nov 20, 2023 · 5 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@rsc
Copy link
Contributor

rsc commented Nov 20, 2023

CL 543319 needs to be submitted for the release.

@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Nov 20, 2023
@rsc rsc added this to the Go1.22 milestone Nov 20, 2023
@heschi
Copy link
Member

heschi commented Nov 20, 2023

cc @golang/release

@mknyszek mknyszek changed the title iter: add GOEXPERIMENT=rangefunc-limited version iter: add GOEXPERIMENT=rangefunc-limited version [freeze exception] Nov 22, 2023
@mknyszek
Copy link
Contributor

@cherrymui and @heschi both looked at https://go.dev/cl/543319 and concluded that it has no effect with the experiment disabled, so it's safe to land after the freeze.

@rsc in the release meeting, we'd appreciate it if you could elaborate on the justification in the issue, but otherwise the freeze exception is tentatively accepted.

@rsc
Copy link
Contributor Author

rsc commented Dec 5, 2023

The justification is that this change is necessary for people to try GOEXPERIMENT=rangefunc and see the high-performance iter.Pull that we expect rather than the low-performance one that can be implemented without runtime changes. The changes are limited to the implementation of iter.Pull - if you're not using it, there is no risk. And the change are only visible when using GOEXPERIMENT=rangefunc - if you don't set it, you can't get at any of this code. So the risk to the overall release is as close to zero as a change can be.

@cherrymui cherrymui added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 5, 2023
@cagedmantis
Copy link
Contributor

As per discussion in the release meeting, this has been approved.

@cherrymui
Copy link
Member

CL submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Status: Done
Development

No branches or pull requests

5 participants