Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image/gif: local color table transparency is not respected #6441

Closed
gopherbot opened this issue Sep 21, 2013 · 10 comments
Closed

image/gif: local color table transparency is not respected #6441

gopherbot opened this issue Sep 21, 2013 · 10 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 21, 2013

by andybons:

go version devel +125bf33c1905 Sat Sep 21 17:53:44 2013 +1000 darwin/amd64

Attached is the repro case with the example output as well.

I’ll follow up with more information on the gif that could be causing it, but other
animated gifs seem to work fine.

Attachments:

  1. test.gif (420174 bytes)
  2. test.go (389 bytes)
  3. test1.gif (419790 bytes)
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Sep 21, 2013

Comment 1 by andybons:

It seems it may be an issue with the decoder.

Attachments:

  1. 18th_frame.jpg (10681 bytes)
  2. test.go (448 bytes)
@minux
Copy link
Member

@minux minux commented Sep 22, 2013

Comment 2:

$ gifsicle test.gif '#18' > test-18.gif
the resulting looks exactly like the 18th_frame.jpg you posted, so perhaps
the problem is not Go's image/gif.
@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Sep 22, 2013

Comment 3:

As another data point, gif2png shows a similar thing (frame 18 looks similar to your
18th_frame.jpg, and doesn't look like any previous frames) but test.p18 is mostly
transparent, not mostly opaque black.
@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Sep 23, 2013

Comment 4:

I think the 18th frame actually does look like that (albeit transparent instead of
opaque black). I'd normally close this issue as WorkingAsIntended, but I'll leave it
open for the local color table transparency thing.
I've attached the test.p18 file generated by gif2png.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

Attachments:

  1. test.p18 (5853 bytes)
@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Sep 23, 2013

Comment 5:

I have mailed out https://golang.org/cl/13829043/ but we are currently in the
1.2 code freeze. This will land after 1.2 is released.
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 6:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 7:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 8:

Labels changed: added repo-main.

@nigeltao
Copy link
Contributor

@nigeltao nigeltao commented Dec 18, 2013

Comment 9:

This issue was closed by revision ff6b922.

Status changed to Fixed.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Dec 18, 2013

Comment 10 by dan.pupius:

Nice, thanks!
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.