You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CL 546020 does not possibly break anything, since math/rand/v2 is new. (It was rolled back due to not being big-endian-safe and due to a bug in the RISCV compiler SSA rules; both are fixed.)
CL 516860 makes the runtime start using this code, but the CL looks bigger than it is because I rationalized the names and linkname usage, causing a lot of renaming. The CL has two different random generators in it used by the runtime. The ChaCha8 is used directly in all map creation and iteration, so it is heavily exercised. If it were broken, things would blow up quickly. The "cheap" random generator (code unchanged since before, just repackaged a bit) is used during interface checks, allocation, and any kind of blocking due to the randomized balanced tree of waiters. If it were broken, things would similarly blow up quickly.
So these should both be very low risk. If they were bad, trybots would have failed spectacularly in all kinds of different ways.
As discussed in the release meeting, this has been approved. There are additional considerations that we would like to discuss regarding the release timing.
The path to resolution is known, but the work has not been done.
Feedback is required from experts, contributors, and/or the community before a change can be made.
Dec 5, 2023