Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: document ConnectionState fields #6456

Closed
ThomasHabets opened this issue Sep 23, 2013 · 6 comments
Closed

crypto/tls: document ConnectionState fields #6456

ThomasHabets opened this issue Sep 23, 2013 · 6 comments
Milestone

Comments

@ThomasHabets
Copy link
Contributor

@ThomasHabets ThomasHabets commented Sep 23, 2013

http://tip.golang.org/pkg/crypto/tls/

1) Is it more accurate to say "partially implements TLS 1.2"?

2) What exactly is missing from the implementation? (why "partially"?)

3) type ConnectionState doesn't document all its members. I assume NegotiatedProtocol is
"NextProtos", not, say TLS version used.
@minux

This comment has been minimized.

Copy link
Member

@minux minux commented Sep 23, 2013

Comment 1:

Labels changed: added priority-soon, go1.2, removed priority-triage.

Owner changed to @agl.

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 23, 2013

Comment 2:

CL 13740047

Owner changed to @rsc.

Status changed to Started.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 23, 2013

Comment 3:

This issue was closed by revision bc2c338.

Status changed to Fixed.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Sep 23, 2013

Comment 4:

Owner changed to ---.

Status changed to Accepted.

@ThomasHabets

This comment has been minimized.

Copy link
Contributor Author

@ThomasHabets ThomasHabets commented Sep 24, 2013

Comment 5:

RFC referenced for TLS1.2 should be updated to 5246, not kept at 4346 which is TLS 1.12
@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Oct 3, 2013

Comment 6:

This issue was closed by revision 95d85d9.

Status changed to Fixed.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
FiloSottile pushed a commit to FiloSottile/go that referenced this issue Oct 12, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.