html/template: t.Tree is always nil

[gopherbot]

by yunge.fu:

In pkg/html/template/template.go, the Parse() func do not assign value to t.Tree, which
just be added recently, so it's always nil.

func (t *Template) Parse(src string) (*Template, error) {
        t.nameSpace.mu.Lock()
        t.escaped = false
        t.nameSpace.mu.Unlock()
        ret, err := t.text.Parse(src)
        if err != nil {
                return nil, err
        }
        // In general, all the named templates might have changed underfoot.
        // Regardless, some new ones may have been defined.
        // The template.Template set has been updated; update ours.
        t.nameSpace.mu.Lock()
        defer t.nameSpace.mu.Unlock()
        for _, v := range ret.Templates() {
                name := v.Name()
                tmpl := t.set[name]
                if tmpl == nil {
                        tmpl = t.new(name)
                }
                tmpl.escaped = false
                tmpl.text = v
        }
        return t, nil
}

[rsc]

Comment 1:

Labels changed: added priority-later, go1.3maybe, removed priority-triage.

Status changed to Thinking.

[rsc]

Comment 2:

Rob, please triage.

Labels changed: added go1.2maybe, removed go1.3maybe.

Owner changed to @robpike.

[robpike]

Comment 3:

Labels changed: added priority-soon, go1.2, removed priority-later, go1.2maybe.

Status changed to Accepted.

[robpike]

Comment 4:

Status changed to Started.

[robpike]

Comment 5:

This issue was closed by revision e2e9d1d.

Status changed to Fixed.