Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript/get_issue53955 failing on builders with git < 2.32.0 #64603

Closed
bcmills opened this issue Dec 7, 2023 · 2 comments
Closed
Assignees
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 7, 2023

Go version

5e724cc

What operating system and processor architecture are you using (go env)?

linux-386-longtest at 5e724ccb2b092a6bc294b63c4e33ed1da317ca87

:: Running /workdir/go/src/make.bash with args ["/workdir/go/src/make.bash" "-force"] and env ["HOSTNAME=buildlet-linux-amd64-bullseye-rnf881bdb" "HOME=/root" "SHLVL=0" "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" "DEBIAN_FRONTEND=noninteractive" "USER=root" "GO_STAGE0_NET_DELAY=0s" "GO_STAGE0_DL_DELAY=200ms" "WORKDIR=/workdir" "GOROOT_BOOTSTRAP=/workdir/go1.4" "GO_BUILDER_NAME=linux-386-longtest" "GO_TEST_SHORT=0" "GOARCH=386" "GOHOSTARCH=386" "GO_TEST_TIMEOUT_SCALE=5" "GOBIN=" "TMPDIR=/workdir/tmp" "GOCACHE=/workdir/gocache" "GOPLSCACHE=/workdir/goplscache" "PWD=/workdir/go/src"] in dir /workdir/go/src

What did you do?

https://build.golang.org/log/e630401a8d4e84078c48ea93d992d990e1f04868

What did you expect to see?

Passing tests.

What did you see instead?

--- FAIL: TestScript (0.06s)
    --- FAIL: TestScript/get_issue53955 (0.00s)
        script_test.go:132: 2023-12-07T01:41:22Z
        script_test.go:134: $WORK=/workdir/tmp/cmd-go-test-4072317620/tmpdir4236981540/get_issue539551246582874
        script_test.go:156: 
            # Regression test for https://go.dev/issue/53955.
            # New remote tags were erroneously added to the local clone of a repo
            # only *after* extracting version information for a locally-cached commit,
            # causing the version information to have incomplete Tags and Version fields. (0.002s)
            > [short] skip 'constructs a local git repo'
            [condition not met]
            > [!git] skip
            [condition not met]
            > [!net:github.com] skip 'does not actually use github.com because of insteadOf, but silence network check just in case'
            [condition not met]
            > env GIT_CONFIG_GLOBAL=$WORK/.gitconfig
            > env GIT_ALLOW_PROTOCOL=file
            > env GOPRIVATE=github.com/golang/issue53955
            > [!GOOS:windows] exec git config --global 'url.file://'$WORK'/repo.insteadOf' 'https://github.com/golang/issue53955'
            [stderr]
            error: could not lock config file /no-home/.gitconfig: No such file or directory
        script_test.go:156: FAIL: testdata/script/get_issue53955.txt:14: exec git config --global url.file:///workdir/tmp/cmd-go-test-4072317620/tmpdir4236981540/get_issue539551246582874/repo.insteadOf https://github.com/golang/issue53955: exit status 255
FAIL
FAIL	cmd/go	238.095s
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. labels Dec 7, 2023
@bcmills bcmills self-assigned this Dec 7, 2023
@bcmills bcmills added release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Dec 7, 2023
@bcmills bcmills added this to the Go1.22 milestone Dec 7, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Dec 7, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/548215 mentions this issue: cmd/go: set global .gitconfig location more robustly in tests

ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
Also confirm that setting the location actually worked before
proceeding with the rest of the test.

This fixes a test failure with git versions older than 2.32.0.

Updates golang#53955.
Fixes golang#64603.

Change-Id: I1a954975a3d8300e8b4dca045d3a15438a0407ec
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest
Reviewed-on: https://go-review.googlesource.com/c/go/+/548215
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/585816 mentions this issue: [release-branch.go1.21] cmd/go: set global .gitconfig location more robustly in tests

gopherbot pushed a commit that referenced this issue May 16, 2024
…obustly in tests

Also confirm that setting the location actually worked before
proceeding with the rest of the test.

This fixes a test failure with git versions older than 2.32.0.

For #53955.
For #64603.
Fixes #64586

Change-Id: I1a954975a3d8300e8b4dca045d3a15438a0407ec
Reviewed-on: https://go-review.googlesource.com/c/go/+/548215
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/585816
Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Status: Done
Development

No branches or pull requests

2 participants