-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os,runtime: opening long file paths sometimes fails with The system cannot find the path specified.
as of CL 516860
#64605
Comments
Change https://go.dev/cl/548000 mentions this issue: |
There were some changes in (CC @golang/windows @golang/runtime) |
This is also showing up in
|
The system cannot find the path specified.
as of CL 516860
Is anything printing
at startup? |
Hmm... Not as far as I can see from the logs. 🤔 |
Found new dashboard test flakes for:
2023-12-06 21:38 windows-amd64-2016 tools@003c81d2 go@2e4d9a18 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-06 21:38 windows-amd64-race tools@003c81d2 go@4bf1ca4b x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-06 21:38 windows-amd64-race tools@003c81d2 go@4601857c x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-08 20:11 windows-amd64-race tools@c4e846a7 go@e1cba47e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-12-08 22:31 windows-amd64-2016 tools@8e821ab4 go@f360ffd9 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
|
I thought this was a consistent failure. Why are we seeing it reported as flakes? |
Change https://go.dev/cl/548635 mentions this issue: |
Found new dashboard test flakes for:
2023-12-08 22:31 windows-amd64-2016 tools@8e821ab4 go@fe1b2f95 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-12-04 22:43 windows-amd64-2016 tools@5e672e2c go@459cd35e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-2016 tools@5e672e2c go@3f2bf706 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-2016 tools@5e672e2c go@5214949d x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-2016 tools@5e672e2c go@c002a5d8 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-race tools@5e672e2c go@3f2bf706 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-race tools@5e672e2c go@c80bd631 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-race tools@5e672e2c go@5214949d x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
2023-12-04 22:43 windows-amd64-race tools@5e672e2c go@01dfae91 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens (log)
|
Found new dashboard test flakes for:
2023-12-13 00:22 gotip-windows-amd64-race go@400e24a8 go/types.TestSelf (log)
2023-12-30 00:23 gotip-windows-386 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64 go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64-longtest go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:23 gotip-windows-amd64-race go@3233542e net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-386 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64 go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64-longtest go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2023-12-30 00:24 gotip-windows-amd64-race go@b25f5558 net.TestLookupDotsWithRemoteSource (log)
2024-01-08 18:52 gotip-windows-amd64-longtest go@8eaa7935 cmd/go.TestScript/mod_prefer_compatible (log)
|
CL 516860 accidentally changed the randomness used in TempFile from 32 to 64 bits on 64-bit platforms, meaning from 10 to 20 decimal bytes. This is enough to cause problems in a few tests because it makes temporary directory names just a little bit longer. Limit back down to 32 bits of randomness, which is fine, and add a test to avoid repeating the mistake. Fixes golang#64605. Change-Id: I17b8c063d11d5c0a96a68b5e5f83c889a13bca77 Reviewed-on: https://go-review.googlesource.com/c/go/+/548635 Reviewed-by: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Russ Cox <rsc@golang.org>
Go version
c29444e
What operating system and processor architecture are you using (
go env
)?What did you do?
https://build.golang.org/log/d77c2ea8c5ed710eb7a76b9d0c6ed83e8b65e5fc
What did you expect to see?
All tests passing.
What did you see instead?
This failure mode is consistent across test runs, and only occurs on Windows.
It started as of https://go.dev/cl/516860, but I have no idea how that change could be causing that failure mode.
The error message comes from here:
https://cs.opensource.google/go/go/+/master:src/internal/fuzz/fuzz.go;l=998;drc=14ab998f95b53baa6e336c598b0f34e319cc9717
The text was updated successfully, but these errors were encountered: