Skip to content

x/tools/internal/robustio: TestFileInfo missing feature guards for symlinks and hard-links #64701

@bcmills

Description

@bcmills

Go version

N/A

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

Check x/tools build status on https://ci.chromium.org/p/golang/g/x-tools-gotip/console.

What did you expect to see?

All tests passing.

What did you see instead?

https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-wasip1-wasm_wasmtime/b8761809133576738257/test-results:

=== RUN   TestFileInfo
    robustio_test.go:57: can't create symbolic link: symlink /tmp/TestFileInfo2274051770/002/real /tmp/TestFileInfo2274051770/004/symlink: Operation not permitted
--- FAIL: TestFileInfo (2.00s)

In general calls to os.Symlink and os.Link can fail on certain configurations of Windows, Android, and wasip1. See testenv.HasSymlink and testenv.HasLink in the main repo.

(attn @findleyr @adonovan)

Metadata

Metadata

Assignees

Labels

FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.TestingAn issue that has been verified to require only test changes, not just a test failure.ToolsThis label describes issues relating to any tools in the x/tools repository.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions