Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: race condition raised with parallel tests, panic(nil) and -race [1.21 backport] #64757

Closed
gopherbot opened this issue Dec 15, 2023 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link
Contributor

@dr2chase requested issue #64649 to be considered for backport to the next 1.21 minor release.

@gopherbot please consider this for backport to 1.21. It broke someone's integration tests, and since GODEBUG=panicnil (or go.mod version = 1.20) is a compatibility feature added to 1.21, it is a regression, if you look at it right.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 15, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 15, 2023
@gopherbot gopherbot added this to the Go1.21.6 milestone Dec 15, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/550236 mentions this issue: [release-branch.go1.21] runtime: add race annotations in IncNonDefault

@cagedmantis
Copy link
Contributor

Approved pending a small additional CL.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Dec 20, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 20, 2023
@dr2chase
Copy link
Contributor

dr2chase commented Jan 3, 2024

Small additional CL was merged into CL 550236

@gopherbot
Copy link
Contributor Author

Closed by merging 8c6078a to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Jan 4, 2024
Also use CompareAndSwap to make the code actually less racy.

Added a test which will be meaningful when run under the race
detector (tested it -race with broken fix in runtime, it failed).

This backport incorporates the correction in CL 551856,
using racereleasemerge instead of racerelease. 

Fixes #64757

Change-Id: I5972e08901d1adc8ba74858edad7eba91be1b0ce
Reviewed-on: https://go-review.googlesource.com/c/go/+/549796
Run-TryBot: David Chase <drchase@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 3313bbb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/550236
Auto-Submit: Matthew Dempsky <mdempsky@google.com>
TryBot-Bypass: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Development

No branches or pull requests

3 participants