Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/big: nat.mulRange produces incorrect results for large input arguments #65025

Closed
griesemer opened this issue Jan 8, 2024 · 1 comment
Closed

math/big: nat.mulRange produces incorrect results for large input arguments #65025

griesemer opened this issue Jan 8, 2024 · 1 comment
Assignees
@griesemer
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.22

Comments

@griesemer
Copy link
Contributor

Go version

go version devel go1.22-8eaa7935db Mon Jan 8 18:52:56 2024 +0000 darwin/amd64

Output of go env in your module/workspace:

irrelevant

What did you do?

mulRange(math.MaxUint64 - 3, math.MaxUint64) overflows the internal median computation
(reported by jannotti@gmail.com)

What did you see happen?

incorrect result / stack overflow

What did you expect to see?

correct result
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 8, 2024
@griesemer griesemer added this to the Go1.22 milestone Jan 8, 2024
@griesemer griesemer self-assigned this Jan 8, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/554617 mentions this issue: math/big: fix uint64 overflow in nat.mulRange

ezz-no pushed a commit to ezz-no/go-ezzno that referenced this issue Feb 18, 2024
@griesemer @ezz-no
math/big: fix uint64 overflow in nat.mulRange
e5729ae 
Compute median as a + (b-a)/2 instead of (a + b)/2.
Add additional test cases.

Fixes golang#65025.

Change-Id: Ib716a1036c17f8f33f51e33cedab13512eb7e0be
Reviewed-on: https://go-review.googlesource.com/c/go/+/554617
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
Reviewed-by: Rob Pike <r@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
@golang golang locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@griesemer griesemer

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@griesemer @gopherbot