Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/marker: Test failures #65072

Closed
gopherbot opened this issue Jan 12, 2024 · 10 comments
Closed

x/tools/gopls/internal/test/marker: Test failures #65072

gopherbot opened this issue Jan 12, 2024 · 10 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: Test (1.30s)
    --- FAIL: Test/suggestedfix/issue65024.txt (1.74s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 12, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2024-01-11 23:11 linux-386-longtest tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (1.30s)
    --- FAIL: Test/suggestedfix/issue65024.txt (1.74s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-386-longtest tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.76s)
    --- FAIL: Test/suggestedfix/issue65024.txt (5.48s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-amd64-longtest tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (1.02s)
    --- FAIL: Test/suggestedfix/issue65024.txt (1.36s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-amd64-longtest tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.77s)
    --- FAIL: Test/suggestedfix/issue65024.txt (5.22s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-amd64-longtest-race tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.78s)
    --- FAIL: Test/suggestedfix/issue65024.txt (6.10s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-amd64-longtest-race tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.57s)
    --- FAIL: Test/suggestedfix/issue65024.txt (2.04s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-arm64-longtest tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.68s)
    --- FAIL: Test/suggestedfix/issue65024.txt (0.84s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 linux-arm64-longtest tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (0.72s)
    --- FAIL: Test/suggestedfix/issue65024.txt (3.70s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 windows-amd64-longtest tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (2.07s)
    --- FAIL: Test/suggestedfix\issue65024.txt (23.32s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix\issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 windows-amd64-longtest tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (2.23s)
    --- FAIL: Test/suggestedfix\issue65024.txt (21.07s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix\issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 12, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 12, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2024-01-11 23:11 darwin-amd64-longtest tools@f572b7ef go@b2dbfbfc x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (8.11s)
    --- FAIL: Test/suggestedfix/issue65024.txt (13.75s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -
2024-01-11 23:11 darwin-amd64-longtest tools@f572b7ef go@0f3876f8 x/tools/gopls/internal/test/marker.Test (log)
--- FAIL: Test (3.07s)
    --- FAIL: Test/suggestedfix/issue65024.txt (11.61s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -

watchflakes

@callthingsoff
Copy link
Contributor

x/tools is fixed by https://go.dev/cl/555555.

@kleinkk76
Copy link

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: Test (1.30s)
    --- FAIL: Test/suggestedfix/issue65024.txt (1.74s)
        marker_test.go:301: a/v2/b/b.go:7:21 (suggestedfix/issue65024.txt:25:21): suggestedfix: wrong diff for a/v2/b/b.go:

            got:
            @@ -7 +7,5 @@
            +// F implements a.I.
            +func (b *B) F() a.T {
            +	panic("unimplemented")
            +}
...
            +import a "testdata/a-a/v2"
            +
            @@ -7 +9,5 @@
            +// F implements a.I.
            +func (*B) F() a.T {
            +	panic("unimplemented")
            +}
            +
            @@ -10 +17 @@
            -

watchflakes

@kleinkk76
Copy link

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"

@hyangah
Copy link
Contributor

hyangah commented Jan 17, 2024

Looks like watchflakes stopped complaining after cl/555555.
Closing.

@hyangah hyangah closed this as completed Jan 17, 2024
@gopherbot gopherbot reopened this Jan 26, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2024-01-23 17:50 x_tools-go1.22-solaris-amd64 tools@6a58b984 release-branch.go1.22@1e1da491 x/tools/gopls/internal/test/marker.Test [ABORT] (log)
=== RUN   Test/codeaction/import-shadows-builtin.txt
=== PAUSE Test/codeaction/import-shadows-builtin.txt
=== CONT  Test/codeaction/import-shadows-builtin.txt

watchflakes

@findleyr findleyr self-assigned this Jan 30, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Jan 30, 2024
@findleyr
Copy link
Contributor

Solaris slowness... Perhaps we should skip this with -short on solaris.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/marker" && test == "Test"
2024-02-01 23:04 linux-amd64-race tools@c07f9276 go@01c93ad0 x/tools/gopls/internal/test/marker.Test (log)
==================
WARNING: DATA RACE
Read at 0x00c0281ede8c by goroutine 98546:
  go/types.(*object).color()
      /workdir/go/src/go/types/object.go:159 +0x38
  go/types.(*TypeName).color()
      <autogenerated>:1 +0x17
  go/types.(*Checker).objDecl()
      /workdir/go/src/go/types/decl.go:96 +0x3dd
  go/types.(*Checker).ident()
...
--- FAIL: Test (0.55s)
    --- FAIL: Test/hover/linkable.txt (0.63s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/hover/hover.txt (0.62s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/hover/issues.txt (0.73s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/hover/goprivate.txt (0.45s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/hover/generics.txt (0.53s)
...
    --- FAIL: Test/highlight/issue60435.txt (3.88s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/highlight/highlight.txt (4.39s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/completion/lit.txt (30.31s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/completion/foobarbaz.txt (13.02s)
        testing.go:1465: race detected during execution of test
    --- FAIL: Test/completion/func_rank.txt (13.32s)
        testing.go:1465: race detected during execution of test

watchflakes

@findleyr
Copy link
Contributor

No flakes since Feb 1. Let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

5 participants