-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/playground: support running tests #6511
Comments
Owner changed to @adg. Status changed to Accepted. |
Labels changed: added repo-playground, removed priority-triage, repo-main. Owner changed to @josharian. Status changed to Started. |
CL https://golang.org/cl/102420043 mentions this issue. |
@adg any new thoughts about this? I could bring that old CL back to life if you were interested. |
If we're to do this, we could be more general: extend the API to accept multiple input files, which are built together as a package. We could even permit building a tree of packages. Then we could provide execution options (run, test, bench, others?) to run against those packages. I think the implementation of this would be pretty straightforward. The hardest part would be designing a nice JSON API for the requests. |
@adg, we could even introduce magic comments as a way to mark new files, which is common in people's bug reports anyway. But I see no reason to tie that feature to this. They seem separable. |
Change https://golang.org/cl/98155 mentions this issue: |
I have committed a change based mostly on the way @josharian did it 3.5 years ago. I was going different direction at first but ended with something very close to that old change by Josh. At worst it was very good learning experience for me. I would be glad of somebody gave it a proper review. |
The text was updated successfully, but these errors were encountered: