Skip to content

x/website: wiki doesn't shrink images to fit on the screen #65139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prattmic opened this issue Jan 17, 2024 · 4 comments
Closed

x/website: wiki doesn't shrink images to fit on the screen #65139

prattmic opened this issue Jan 17, 2024 · 4 comments
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone

Comments

@prattmic
Copy link
Member

https://go.dev/wiki/LUCI contains a high-resolution screenshot, which on my screen overflows off the right side of the screen, like below:

image

IMO, this should be automatically shrunk to fit in the same width as the text.

cc @rsc

@gopherbot gopherbot added this to the Unreleased milestone Jan 17, 2024
@prattmic
Copy link
Member Author

The custom CSS

.Article img {
    width: 100%;
}

Fixes this for me, but I'm not sure that is the best fix. (Will that stretch images that are too small?)

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 17, 2024
@cagedmantis
Copy link
Contributor

cc @golang/tools-team

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/556416 mentions this issue: _content/css: set img max width to 100%

@hyangah
Copy link
Contributor

hyangah commented Jan 17, 2024

In https://go.dev/cl/556416, proposing

max-width: 100%

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 17, 2024
@golang golang locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Development

No branches or pull requests

5 participants