x/tools/gopls: unnecessary eta abstraction while removing parameter #65217
Labels
gopls
Issues related to the Go language server, gopls.
Refactoring
Issues related to refactoring tools
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
In CL 557496, we observed that removing an unused parameter resulted in an unnecessary eta abstraction:
From:
To:
In this case, I'm sure it's the effect detection that triggers the literalization, but that's not correct. There is no change in effects before and after the parameter is removed, since the unused parameter has no side effects.
This is probably an artifact of how parameter removal is implemented via inlined wrappers.
CC @adonovan @suzmue
The text was updated successfully, but these errors were encountered: