-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: allow empty login in auth by netrc #65260
Comments
Note that the Per that documentation (emphasis mine):
That seems to imply that if the See also: which seems to suggest that GitHub takes the opposite approach, encoding the token as the |
curl successfuly parse netrc file without login field. Where to need? For example gitlab uses only password from authorization header while `go get` Fixes golang#65260
Change https://go.dev/cl/557956 mentions this issue: |
Maybe if the login token is not present, the auto-login process should initiate without a login name? For example, curl successfully parses the netrc file without a login field. |
We need to learn more about this. Like Bryan said in his comment on #40215 it seems like github and gitlab are expecting their tokens in the opposite places. |
Gitlab documentation for cloning says the username can be any string but must not be empty. |
Okay, in that case it seems like we should keep the behavior as is? |
I'm in favour of keeping things as is. |
We're going to close this issue. Please open another issue if there's a workflow issue that can't be solved using the current tooling. |
Go version
go1.21.5
Output of
go env
in your module/workspace:What did you do?
What did you see happen?
What did you expect to see?
Why?
curl use empty login if login not specified in
.netrc
and it's work normally becausegitlab
uses only password from authorization token.Proff:
The text was updated successfully, but these errors were encountered: