Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: adjust suggestions for wiki repo #65281

Open
hyangah opened this issue Jan 25, 2024 · 3 comments
Open

x/build/cmd/gerritbot: adjust suggestions for wiki repo #65281

hyangah opened this issue Jan 25, 2024 · 3 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 25, 2024

The robot spotted two issues in the commit message of CL/556115.

Re: point1 - x/wiki is not organized based on packages. So, the suggestion doesn't seem very relevant.

Re: point2 - maybe too much to ask for a CL to fix a single typo fix? (debatable) Since this is a GitHub PR workflow CL, this needs to be fixed from the github PR page, but most of us don't have permission to do so.

@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2024
@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 25, 2024
@cherrymui cherrymui changed the title x/wiki: adjust gopherbot suggestion for x/wiki x/build/cmd/gopherbot: adjust gopherbot suggestion for x/wiki Jan 25, 2024
@cherrymui
Copy link
Member

cc @golang/release

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 25, 2024
@cherrymui cherrymui added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Jan 25, 2024
@dmitshur
Copy link
Contributor

CC @thepudds. Is this something you're interested in taking a look at? Thanks.

@thepudds
Copy link
Contributor

Hi @dmitshur -- yes, I will plan to address this soon. The gerritbot rules have not yet been updated to take into account the existence of wiki repo.

The solution for point 1 is straightforward. The best solution for point 2 might be slightly debatable. I'll post a couple brief thoughts on that in a bit.

Thanks for the ping!

@thepudds thepudds self-assigned this Jan 26, 2024
@dmitshur dmitshur changed the title x/build/cmd/gopherbot: adjust gopherbot suggestion for x/wiki x/build/cmd/gopherbot: adjust gopherbot suggestion for wiki repo Jan 26, 2024
@dmitshur dmitshur changed the title x/build/cmd/gopherbot: adjust gopherbot suggestion for wiki repo x/build/cmd/gerritbot: adjust suggestions for wiki repo Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Planned
Development

No branches or pull requests

5 participants