x/tools/gopls/internal/cmd: TempDir RemoveAll cleanup fail

[gopherbot]

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && `TempDir RemoveAll cleanup: remove .*: The process cannot access the file because it is being used by another process`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestPrepareRename
=== PAUSE TestPrepareRename
=== CONT  TestPrepareRename
    testing.go:1231: TempDir RemoveAll cleanup: remove C:\Users\swarming\.swarming\w\ir\x\t\TestPrepareRename1219571028\001: The process cannot access the file because it is being used by another process.
--- FAIL: TestPrepareRename (8.25s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestPrepareRename"

2024-01-05 15:29 x_tools-go1.22-windows-arm64 tools@3e8a0a3b release-branch.go1.22@fa72f3e0 x/tools/gopls/internal/cmd.TestPrepareRename (log)

=== RUN   TestPrepareRename
=== PAUSE TestPrepareRename
=== CONT  TestPrepareRename
    testing.go:1231: TempDir RemoveAll cleanup: remove C:\Users\swarming\.swarming\w\ir\x\t\TestPrepareRename1219571028\001: The process cannot access the file because it is being used by another process.
--- FAIL: TestPrepareRename (8.25s)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && `TempDir RemoveAll cleanup: remove .*: The process cannot access the file because it is being used by another process`

2023-12-15 21:03 x_tools-go1.20-windows-amd64-longtest tools@e601fd80 release-branch.go1.20@8cb86b5f x/tools/gopls/internal/cmd.TestExecute (log)

=== RUN   TestExecute
=== PAUSE TestExecute
=== CONT  TestExecute
    testing.go:1206: TempDir RemoveAll cleanup: remove C:\b\s\w\ir\x\t\TestExecute2613003941\001: The process cannot access the file because it is being used by another process.
--- FAIL: TestExecute (25.59s)

— watchflakes

[bcmills]

This indicates either a very slow builder, or (probably more likely?) a file handle or subprocess leaked in the course of the test.

Perhaps the gopls process created by the test leaked a go list child process?

See previously:

• testing: "Access is denied." when cleaning up TempDir on windows-amd64-2012 #50051

[adonovan]

Perhaps the gopls process created by the test leaked a go list child process?

From the lack of t.Errorf lines in the log, I think this test otherwise passed, which means gopls exited already, and I can't immediately see why it would leave a go list or any other child process behind.

[findleyr]

This might be #65180.

[findleyr]

I'm going to eagerly close this, hoping that it was fixed along with #65180.